This repository has been archived by the owner on Oct 20, 2023. It is now read-only.
Timeline UI Updates #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
March 2, 2023 16:16
arniebradfo
commented
Mar 6, 2023
| cy.get('[cy-test=timeline-animated-line]') | ||
| .invoke('attr', 'x1') | ||
| cy.get('[cy-test=timeline-scrubber]') | ||
| .invoke('attr', 'x1') // @QA - we are now moving the scrubber using `style="transform:translateX(00px)"`, not `x1` & `x2` |
There was a problem hiding this comment.
@sang2925 && || @ccarpenter28,
I've updated the scrubber referenced in this test to change its position using transform rather than the x1 and x2 attributes.
arniebradfo
requested review from
sharplessHQ and
GoldingAustin
and removed request for
sharplessHQ
GoldingAustin
approved these changes
Mar 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the timeline UI
store.campaign.timeline.setScrubberTimeAny(time)rather than...setScrubberTimeExact(time)TimelineBarHoverPopoverTesting
Timeline Interactions
Screenshots
Before & After (notice blurry vs pixel aligned svg)
